feat: add docker container table #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnart
changed the title
ajnart
changed the title
Meierschlumpf
requested changes
May 18, 2024
Meierschlumpf
requested changes
May 19, 2024
apps/nextjs/src/app/[locale]/manage/tools/docker/DockerTable.tsx
Outdated
Show resolved
Hide resolved
Include container actions and state badges
This commit refactors the DockerSingleton class in the `docker.ts` file to use the `host` and `instance` properties instead of the previous `key` and `remoteApi` properties. This change improves clarity and consistency in the codebase.
This commit enhances the DockerTable component in the `DockerTable.tsx` file by adding an Avatar and Name column. The Avatar column displays an icon based on the Docker container's image, while the Name column shows the container's name. This improvement provides better visual representation and identification of the containers in the table.
Meierschlumpf
previously approved these changes
May 29, 2024
|
One think I'm not sure about is why you used a black background arround the table and all? |
|
This is not entirely ready, I need to think about other stuff |
Maybe we can merge this pull request just as |
Meierschlumpf
changed the title
Meierschlumpf
approved these changes
May 29, 2024
|
It's fine as is, I don't think anyone has time to read the commit history of every file x) |
|
Let's merge, I'll add to it later |
This was referenced Jun 1, 2024
This was referenced Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homarr
Thank you for your contribution. Please ensure that your pull request meets the following pull request:
pnpm buid, autofix withpnpm format:fix)devbranchx,y,ior any abbrevation)