Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate dual derivations automatically #1468

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

zickgraf
Copy link
Member

We can generate about 1/3 of all derivations in CAP automatically by dualizing existing derivations.

This might contain some regressions due to #1460 and #1465 which will automatically fixed once the issue/PR are addressed.

@zickgraf
Copy link
Member Author

This PR now also speeds up precompilation of categories in tests by using overhead := false. See #1469 for why this is needed.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 141 lines in your changes are missing coverage. Please review.

Files Coverage Δ
CAP/PackageInfo.g 100.00% <100.00%> (ø)
CAP/gap/CAP.gi 58.43% <100.00%> (+0.30%) ⬆️
CAP/gap/Finalize.gi 75.88% <100.00%> (+1.08%) ⬆️
CAP/gap/InstallAdds.gi 78.18% <ø> (ø)
CAP/gap/LimitConvenienceOutput.gi 66.66% <ø> (-1.40%) ⬇️
CAP/read.g 100.00% <100.00%> (ø)
CompilerForCAP/PackageInfo.g 100.00% <100.00%> (ø)
CompilerForCAP/gap/LogicTemplates.gi 99.12% <100.00%> (+0.03%) ⬆️
CompilerForCAP/gap/PrecompileCategory.gi 100.00% <100.00%> (ø)
FreydCategoriesForCAP/PackageInfo.g 100.00% <100.00%> (ø)
... and 8 more

📢 Thoughts on this report? Let us know!.

@zickgraf zickgraf merged commit 973f3af into homalg-project:master Sep 26, 2023
4 checks passed
@zickgraf zickgraf deleted the dual_derivations branch September 26, 2023 09:50
@mohamed-barakat
Copy link
Member

Congratulations 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants