Implement GPU-accelerated edge bundling#1124
Open
scottagfox wants to merge 2 commits intoholoviz:mainfrom
Open
Implement GPU-accelerated edge bundling#1124scottagfox wants to merge 2 commits intoholoviz:mainfrom
scottagfox wants to merge 2 commits intoholoviz:mainfrom
Conversation
Added alternate, faster edge bundling method on GPU.
|
@ianthomas23 Would love it if you reviewed this and suggested next steps. |
Member
|
Looks cool, thanks! Before we could release it we'd need some documentation, preferably including comparisons with the existing edge bundling, and some tests. I don't suppose NVidia has ever worked out a way we could get CUDA-enabled workers for our Github Actions so we can keep this working? :-) |
|
@jbednar we are in the process on updating our DevOps to enable more testing with external libraries using GitHub Actions, though that would still only be accessible within NVIDIA. We'll work on getting some more docs for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FFT bundling is an alternative edge bundling method to Datashader's existing Edgehammer bundling implementation. It runs magnitudes faster than Edgehammer on larger graphs (10k+ edges) thanks to GPU-acceleration and cuFFT.
FFT bundling takes input in the form of two dataframes (cuDF or Pandas) containing normalized node coordinates and an edge list, and outputs a cuDF dataframe containing line segments.
Performance and the end result depend greatly on several parameters:
The FFT edge bundling pipeline is similar to Edgehammer's with a few key differences.
Pipeline:
FFT bundling is still missing some features supported by the Edgehammer bundling method and could use some additional features such as support for weighted graphs, and 'batching' edges to avoid memory constraints. @ianthomas23 mentioned introducing it as an "experimental" feature for now.
@exactlyallan