-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make scaffolding cli package manager agnostic #316
Conversation
60e0af4
to
0b35b7a
Compare
891843b
to
00027f0
Compare
f39e248
to
30490bd
Compare
@@ -1,6 +1,37 @@ | |||
# Holochain Scaffolding CLI | |||
|
|||
CLI to easily generate and edit holochain apps. | |||
A command-line interface for creating and modifying a Holochain application (hApp). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pdaoust I'd like to know whether this doc should be in the developer reference rather than here in the scaffolding cli?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😬 that is a very good question for which I have no answer. Ideally we'd have documentation 'wherever the dev finds themselves', so I would like to say 'yes to both places'. But that creates duplicated content. I wonder if we could write something that would inline it into the docs-pages
build pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can publish this through Rust docs and then add a link to it in the developer guide, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm...it seems to me that the --package-manager
option should not be at the top level but instead be an option of the web-app
and example
subcommands as it does not seem to have any effect beyond the initial web-app scaffolding step.
And in case that makes sense to you then I think it would be quite nice to have an interactive selection step where one can choose the package manager explicitly, akin to how the UI framework can be chosen.
Good idea, thought I would give it the same treatment as the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love all the new documentation! Just one question that may be important. Don't know whether that should be a 'comment' or 'request changes'.
templates/custom-template/custom-template/template/web-app/package.json.hbs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! This PR is a nice improvement :)
Closes #268
Depends on #313