Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 0.1 #177

Merged
merged 6 commits into from
Jan 12, 2024
Merged

Backport 0.1 #177

merged 6 commits into from
Jan 12, 2024

Conversation

c12i
Copy link
Collaborator

@c12i c12i commented Jan 11, 2024

No description provided.

ThetaSinner and others added 5 commits January 11, 2024 17:18
Update gitignore to include rust `target` and ui `node_modules` dirs
Remove duplicate unit tests and run them in ci
…ven-to-select

Handle error creating linked `ActionHash` or `EntryHash` without previous entry-types existing
@c12i c12i requested a review from ThetaSinner January 11, 2024 14:27
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check compatibility with the js client for 0.1 please, otherwise looks good

@ThetaSinner
Copy link
Member

Would it be possible to back-port this one? #141

@c12i
Copy link
Collaborator Author

c12i commented Jan 12, 2024

Would it be possible to back-port this one? #141

Sure I guess this was unintentionally omitted in #160?

@c12i c12i requested a review from ThetaSinner January 12, 2024 11:13
@ThetaSinner
Copy link
Member

Sure I guess this was unintentionally omitted in #160?

Oh good spot, there is a comment on #160 about why that wasn't backported, sorry it also won't work with the older client. I think I left that label in place with the intention to backport the dhtSync change... But given how close we are to releasing 0.3 I wonder if that's really worth it now

Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@c12i c12i merged commit eb3b089 into holochain:develop-0.1 Jan 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants