Setting up nix is optional for example apps #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhoracek
force-pushed
the
hello-world-nix-setup-is-optional
branch
from
0e9d2c6
to
626ef68
Compare
Merged
ThetaSinner
force-pushed
the
hello-world-nix-setup-is-optional
branch
from
626ef68
to
d828a50
Compare
ThetaSinner
added
ShouldBackport/0.1
|
Is the error you ran into like this? #156 I think this option makes sense. I don't see why we wouldn't allow Nix to be skipped here |
|
One small change in two places please. Where the With that change I think this is good to go :) |
ThetaSinner
force-pushed
the
hello-world-nix-setup-is-optional
branch
from
d828a50
to
f065695
Compare
ThetaSinner
force-pushed
the
hello-world-nix-setup-is-optional
branch
from
f065695
to
9cd98e1
Compare
c12i
requested changes
Jan 15, 2024
|
@emhoracek any chance you could give this PR a quick update and tackle the feedback? Happy to get this merged soon. |
c12i
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just did this to make it easier to test out the fixes I made to the Vue scaffolding. I'm new to Nix so I'm not sure it was necessary - maybe there's some other work-around. The problem was that I made a Nix environment so I could build the project, but then I couldn't run my compiled code because it was trying to start a Nix environment inside the Nix environment. So I added this flag so I could tell the example set-up not to setup Nix.