Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template sweep -- fix bugs in Vue and Lit #130

Closed
wants to merge 11 commits into from

Conversation

pdaoust
Copy link
Collaborator

@pdaoust pdaoust commented Oct 3, 2023

I don't claim this is a thorough sweep that catches all bugs, but it does catch all bugs discovered via following the Getting Started Guide but choosing Lit and Vue instead of Svelte for the templating engine.

@ThetaSinner
Copy link
Member

ThetaSinner commented Nov 2, 2023

@pdaoust Same with this one, please can it target develop? Then would you be willing to go through and comment on the PR with a description of what is being changed/fixed so I can do some testing?

I'm happy reviewing the code but I don't know the repo well enough to understand what's changing without having a conversation about it if that's okay! :)

@ThetaSinner ThetaSinner self-requested a review November 2, 2023 15:18
@ThetaSinner ThetaSinner force-pushed the 2023-10-03-fix-vue-lit-templates branch from 56cb4dd to 3ca29ed Compare November 3, 2023 16:52
@ThetaSinner ThetaSinner added ShouldBackport/0.1 This change should be backported to develop-0.1 ShouldBackport/0.2 This change should be backported to develop-0.2 labels Nov 3, 2023
@ThetaSinner ThetaSinner changed the base branch from holochain-0.1 to develop November 3, 2023 16:52
@ThetaSinner
Copy link
Member

This is now ready for review and can be merged when ready

@c12i c12i self-requested a review January 17, 2024 20:19
Copy link
Collaborator

@c12i c12i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discovered similar bugs, at least for the Vue and Svelte templates hence why I am returning to this PR, I think we should be getting this PR merged as it does address some critical issues

@pdaoust kindly let me know if you are in a position to resolve the merge conflicts

src/scaffold/entry_type.rs Outdated Show resolved Hide resolved
@c12i
Copy link
Collaborator

c12i commented Sep 25, 2024

@pdaoust, allow me to close this PR since it is stale at the moment and most of the changes made here have long been addressed

@pdaoust
Copy link
Collaborator Author

pdaoust commented Oct 1, 2024

Sure @c12i . Are there any fixes that haven't already been made? Should I do a new PR with those?

@pdaoust pdaoust closed this Oct 1, 2024
@c12i
Copy link
Collaborator

c12i commented Oct 2, 2024

Thanks @pdaoust, I don't think there are any changes at the moment, I inadvertently addressed them while transitioning the templates to the new styling.

@c12i c12i deleted the 2023-10-03-fix-vue-lit-templates branch October 25, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ShouldBackport/0.1 This change should be backported to develop-0.1 ShouldBackport/0.2 This change should be backported to develop-0.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants