Use @spartan-hc/holo-hash for managing holo-hashes #259
+41
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jost-s do you see value in this? |
jost-s
reviewed
Jul 1, 2024
mjbrisebois
commented
Jul 2, 2024
src/utils/base64.ts
Outdated
| } | ||
|
|
||
| export * from "@spartan-hc/holo-hash"; |
There was a problem hiding this comment.
This causes ambiguity because the HoloHash classes have the same name as all the types.ts exports. How should we export the class implementations without conflict?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a quick example of how we could start using a library to manage holo-hashes while preserving legacy support.
Most of the helper functions in utils could be replaced by the native methods on
HoloHashinstances.sliceDhtLocation=><HoloHash>.getDHTLocationsliceCore32=><HoloHash>.getHashsliceHashType=><HoloHash>.getPrefix