Valid fake hashes & additional hash helper utilities #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 04bf0b3.
…me functions for consistency
mattyg
changed the title
…hash, in order to generate a determanistic fake hash
mattyg
changed the title
|
@jost-s tagging you to request review since I can't don't have permission to assign you. |
jost-s
approved these changes
Nov 28, 2023
|
@jost-s should be all set -- I don't have permission to merge |
|
Great, and thanks for the changelog! |
jost-s
pushed a commit
that referenced
this pull request
Nov 29, 2023
* feat: produce valid fake hashes with valid checksum * fix: core of hash is 32 bytes * fix: hash * Revert "fix: hash" This reverts commit 04bf0b3. * fix: hash fn * fix: hash length * feat: add functions to slice hash into prefix, core, and dht location bytes * chore: comment * feat: add functions to generate full hash from core 32 and type, rename functions for consistency * chore: rename test utils to common to make room for tests against utilty functions * chore: remove unused hash types * test: tests that fake hash functions produce valid hashes * build: fix typescript module declaration for @bitgo/blake2b * doc: generate docs * feat: specify a core byte to repeate for all core 32 bytes of a fake hash, in order to generate a determanistic fake hash * test: add tests for hash slice and hash construct utils * chore: capital-case hashTypePrefix dict * chore: spelling * doc: changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dhtLocationFrom32to construct valid dht location bytes from core 32 bytesfakeAgentPubKey,fakeEntryHash,fakeActionHash,fakeDnaHashto produce valid hashes, and to optionally take a paramcoreBytewhich will be repeated for all core 32 bytessliceDhtLocation,sliceCore32,sliceHashTypehashFrom32AndTypehashTypePrefixto store hash type label -> hash type bytes@bitgo/blake2bFeel free to rename functions as you please.