Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for Holochain 0.3 #462

Merged
merged 14 commits into from
Jul 29, 2024
Merged

Update docs for Holochain 0.3 #462

merged 14 commits into from
Jul 29, 2024

Conversation

pdaoust
Copy link
Collaborator

@pdaoust pdaoust commented Jul 24, 2024

  • Update scaffolding flow and output samples
  • Update code samples
  • Change language that talks about Launcher using Tauri
  • A few prose reorganisations to make it flow better with the new scaffolding flow
  • Language tweaks, esp around hc spin and hc launch
  • Fix broken link
  • Add mention of p2p Shipyard

Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few minor comments which may or may not be useful :)

```text
? Choose UI framework: (Use arrow-keys. Return to submit) ›
lit
❯ svelte
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what other people know around Holo know but I think Svelte is probably a bit less well known in general? I wonder if we should consider switching to the React template now that's available. React, Angular and Vue top the popularity charts, in that order. So we have a better chance of somebody knowing what they're looking at with React

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second this, mostly because of the fact that we are also transitioning to a new styling system, which is already reflected in the react template

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, for that reason alone @c12i I think it'd be worth switching -- less stuff to delete when you start editing the templates :) But also if React is still more popular, that makes sense too. (I don't know what the kids are using these days 😅 )

So I'll start working on a new PR for that, cuz it's a bigger project -- new screenshots etc.

src/pages/get-started/3-forum-app-tutorial.md Outdated Show resolved Hide resolved
src/pages/get-started/3-forum-app-tutorial.md Outdated Show resolved Hide resolved
src/pages/get-started/3-forum-app-tutorial.md Outdated Show resolved Hide resolved
src/pages/get-started/3-forum-app-tutorial.md Outdated Show resolved Hide resolved
src/pages/get-started/3-forum-app-tutorial.md Show resolved Hide resolved
src/pages/get-started/3-forum-app-tutorial.md Show resolved Hide resolved
src/pages/get-started/3-forum-app-tutorial.md Outdated Show resolved Hide resolved
Copy link
Contributor

@matthme matthme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too 👍

src/pages/get-started/3-forum-app-tutorial.md Outdated Show resolved Hide resolved
src/pages/get-started/3-forum-app-tutorial.md Outdated Show resolved Hide resolved
```text
? Choose UI framework: (Use arrow-keys. Return to submit) ›
lit
❯ svelte
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second this, mostly because of the fact that we are also transitioning to a new styling system, which is already reflected in the react template

src/pages/get-started/3-forum-app-tutorial.md Outdated Show resolved Hide resolved
src/pages/get-started/3-forum-app-tutorial.md Show resolved Hide resolved
src/pages/get-started/3-forum-app-tutorial.md Outdated Show resolved Hide resolved
src/pages/get-started/3-forum-app-tutorial.md Outdated Show resolved Hide resolved
src/pages/get-started/4-packaging-and-distribution.md Outdated Show resolved Hide resolved
@pdaoust pdaoust merged commit f56feed into main Jul 29, 2024
6 checks passed
@pdaoust pdaoust deleted the update-for-0.3 branch July 29, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants