Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note about installing ubuntu packages for WSL2 #457

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

pdaoust
Copy link
Collaborator

@pdaoust pdaoust commented Jun 24, 2024

No description provided.

@@ -47,6 +47,12 @@ For Windows users, please note that the Nix package manager, which is used to in

Holochain is supported in WSL2 via the Ubuntu distribution.

You'll also need to install a few packages if you want to run two dev tools, `hc launch` and `hc spin`, which start your app's back end and open its GUI in Tauri or Electron webviews:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are only needed for hc-launch. I never had problems with Tauri needing libraries.

adwaita-icon-theme solves a Tauri specific problem that Electron doesn't seem to have.

I get grouping them together to get people set up quickly. I wonder if it's worth keeping a note somewhere for ourselves about why we're recommending which libraries? I don't know if we can comment in the markdown here without it showing up in the generated page?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, and I can clarify in the advanced install guide.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, yeah that's exactly the kind of information I'd be after - thank you!

@ThetaSinner
Copy link
Contributor

Nice! Thanks for adding this :)

@pdaoust pdaoust merged commit a00399d into main Jun 24, 2024
2 checks passed
@pdaoust pdaoust deleted the hotfix-wsl-tauri-electron-advice branch June 24, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants