Paul's edits to 0.3 upgrade guide #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ThetaSinner
reviewed
Jun 24, 2024
| #[serde(tag = "type")] | ||
| #[hdk_entry_types] | ||
| #[unit_enum(UnitEntryTypes)] | ||
| [derive(Serialize, Deserialize)] |
There was a problem hiding this comment.
These # shouldn't be gone, these are part of the code syntax. I'm assuming they went with the heading changes. Same above
There was a problem hiding this comment.
aha! sure was. ^# was a little too wild of a pattern, I guess...
ThetaSinner
reviewed
Jun 24, 2024
ThetaSinner
reviewed
Jun 24, 2024
|
Currently not building due to a broken link? |
Co-authored-by: ThetaSinner <[email protected]>
|
Broken link fixed; merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some final formatting fixes and a rejiggering of the site structure and redirects. Apologies; the diff is really funky -- the formatting fixes are almost all whitespace/punctuation but it doesn't highlight the differences, and one file is shown as being deleted and recreated, not moved.