Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 0.3 upgrade guide #454
Add 0.3 upgrade guide #454
Changes from 6 commits
ddd9645
a8c39bb
52c28a5
f633ba0
a6b6483
ac01fb0
92059d4
912ec27
d530809
4644065
6e0848f
20eff30
7a6520c
e6ce4f9
adf8820
1484825
771f75c
c17b825
28dc3a9
922a963
689a921
3ba29e5
b853d0d
bdcfe7f
ee0c50d
4805b9c
23cdd31
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, you really moved on that update! Glad to see it in 0.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't that keen on the use of 'stale' here, so I tweaked this a bit. I think stale depends on context. Using 2005's market data for trading in 2024 would be a serious case of stale data. Choosing to work offline and syncing with other people when you next have a network connection to them could be a choice. It could be a requirement though, if you live somewhere with an unreliable connection or use mobile data during the day which is expensive to sync over. To me these situations aren't always about stale data, it's more about having the flexibility to use your data without connectivity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the outcome of this recommendation? FWIU the changes are mainly that previous-action/entry deps for CRUD ops aren't fetched, and instead you're just given a hash. Can we say something about that here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way the scaffolding was updated, it effectively maintains the existing way of doing things. That means that getting back the removed data can be achieved by merging in logic from the scaffolded
lib.rs
in the generated integrity zome.I think the changelog describes this better than I can. Do we want to move something from the changelog to here or is linking to it enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about something like this for the last sentence? "scaffold an app for 0.3 and take a look at how its validation code retrieves the data that's no longer part of the data structures."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.