-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/entries #417
Feat/entries #417
Conversation
e1638b6
to
fe6e852
Compare
…ent into seperate pages in 'Build' section
Responding to @pdaoust's comment from mattyg/pull/4
I'd say yes, unless it starts to seem like the page is too long.
Yeah makes sense. |
I'm going to start massaging the content soon, and I'll prerender the mermaid to SVG like we discussed in Mattermost. |
Note: I've inlined the SVG, so it no longer depends on #412 . |
I just realized that you may not have permission to move this from draft -> PR since I'm the original author, so I just updated it to an actual pr -- not a comment on the readiness I'll leave that to you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright i added a bunch more comments. After those I'm completely satisfied, feel free to merge when you are. Feeling really really good about this. Thanks for all your work!
Co-authored-by: Matt Gabrenya <[email protected]>
Co-authored-by: Matt Gabrenya <[email protected]>
Co-authored-by: Matt Gabrenya <[email protected]>
Build page all about entries
Depends on #412