Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/entries #417

Merged
merged 74 commits into from
Apr 15, 2024
Merged

Feat/entries #417

merged 74 commits into from
Apr 15, 2024

Conversation

mattyg
Copy link
Collaborator

@mattyg mattyg commented Jan 8, 2024

Build page all about entries

Depends on #412

@mattyg mattyg force-pushed the feat/entries branch 2 times, most recently from e1638b6 to fe6e852 Compare January 8, 2024 22:29
@mattyg
Copy link
Collaborator Author

mattyg commented Jan 8, 2024

Responding to @pdaoust's comment from mattyg/pull/4

I think we'll want to decide how long a given page should be, and how much to rely on hyperlinking instead (e.g., should updates go on the entry page? probably.

I'd say yes, unless it starts to seem like the page is too long.

but how about the atomic commit lifecycle? maybe break that out into a separate page cuz it's going to be true for actions of all types -- that sort of thing).

Yeah makes sense.

@pdaoust
Copy link
Collaborator

pdaoust commented Feb 27, 2024

I'm going to start massaging the content soon, and I'll prerender the mermaid to SVG like we discussed in Mattermost.

@pdaoust
Copy link
Collaborator

pdaoust commented Mar 8, 2024

Note: I've inlined the SVG, so it no longer depends on #412 .

@mattyg mattyg marked this pull request as ready for review March 21, 2024 19:00
@mattyg
Copy link
Collaborator Author

mattyg commented Mar 21, 2024

I just realized that you may not have permission to move this from draft -> PR since I'm the original author, so I just updated it to an actual pr -- not a comment on the readiness I'll leave that to you!

Copy link
Collaborator Author

@mattyg mattyg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright i added a bunch more comments. After those I'm completely satisfied, feel free to merge when you are. Feeling really really good about this. Thanks for all your work!

@pdaoust pdaoust merged commit a2c2a06 into main Apr 15, 2024
6 checks passed
@pdaoust pdaoust deleted the feat/entries branch April 15, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants