Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate Acknowledgments for Variants not displayed on CoVariants #233

Open
emmahodcroft opened this issue Nov 30, 2021 · 0 comments
Open

Don't generate Acknowledgments for Variants not displayed on CoVariants #233

emmahodcroft opened this issue Nov 30, 2021 · 0 comments
Assignees
@ivan-aksamentov
Labels
bug Something isn't working help wanted Extra attention is needed scope: scripts

Comments

@emmahodcroft
Copy link
Collaborator

Acknowledgements are generated even if the cluster is set to "type": "do_not_display" in clusters.py - we shouldn't generate acknowledgements for clusters that aren't actually on the webpage (acknowledgements are part of any nextstrain builds that are being generated).

Not super high priority but would help keep things organized as the files are big, so any reduction helps. Currently I'm just going in and deleting these manually.
@emmahodcroft emmahodcroft added bug Something isn't working help wanted Extra attention is needed scope: scripts labels Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivan-aksamentov ivan-aksamentov

Labels
bug Something isn't working help wanted Extra attention is needed scope: scripts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ivan-aksamentov @emmahodcroft