11571 create laboratory order report print view #11572
Conversation
Signed-off-by: DamithDeshan <[email protected]>
Signed-off-by: DamithDeshan <[email protected]>
WalkthroughThis pull request updates the printing functionality of laboratory reports. In the lab inward order report page, button styles and actions were modified to redirect to a new print page. A new XHTML file for printing the test-wise count report has been created, featuring a dynamic table, conditional row rendering, and responsive styling for screen and print formats. Additionally, CSS adjustments were made in another print file to consolidate font size styling from inline attributes to media-specific CSS rules. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant RP as Report Page
participant PP as Print Page
U->>RP: Clicks Print Button
RP->>PP: Redirects to Print Page (lab_inward_order_report_print.xhtml)
PP->>U: Renders Test Wise Count Report layout with print/back options
Possibly related PRs
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/main/webapp/reportLab/lab_inward_order_report.xhtml(1 hunks)src/main/webapp/reportLab/lab_inward_order_report_print.xhtml(1 hunks)src/main/webapp/reportLab/test_wise_count_print.xhtml(3 hunks)
🔇 Additional comments (9)
src/main/webapp/reportLab/lab_inward_order_report.xhtml (2)
236-242: Style improvement on the Download button.The Download button now uses the warning color scheme, which provides better visual distinction from the Process button next to it. This follows a good UI pattern of using different colors for different action types.
244-251: Improved print functionality with dedicated view.The print button has been significantly improved:
- Changed from inline printing to redirecting to a dedicated print view
- Updated with a proper print icon
- Added consistent styling with width specification
- Changed label to be more descriptive
This change enhances user experience by providing a specialized print view rather than printing directly from the data table.
src/main/webapp/reportLab/test_wise_count_print.xhtml (3)
63-66: Good practice: Moving styling to CSS classes for screen media.Moving the font-size styling from inline HTML to a dedicated CSS class improves maintainability and follows best practices for separation of concerns.
114-117: Good practice: Media-specific styling for print.Adding a separate font-size definition for print media ensures the report will be properly sized when printed. The smaller 14px font size for print is appropriate as printed content often appears larger than screen content at the same pixel size.
156-156: Good practice: Removed inline styling.Removing the inline font-size styling and relying on the CSS class is a good improvement for code maintainability and separation of concerns.
src/main/webapp/reportLab/lab_inward_order_report_print.xhtml (4)
1-38: Well-structured print page header with navigation controls.The header section is well organized with:
- Clear title indicating this is a print view
- Print button with printer component targeting the report view
- Back navigation button to return to the report page
- Appropriate styling and icons
This provides good user experience with clear controls for printing and navigation.
40-121: Well-defined CSS for both screen and print media.The CSS includes:
- Specific styles for both screen and print media
- Paper size and zoom settings
- Table and text formatting rules
- Page numbering for printed output
This comprehensive styling ensures the report displays well both on screen and when printed.
176-307: Well-structured report table with conditional rendering.The table implementation:
- Uses appropriate column widths and alignments
- Handles different row types (Bill and BillItem) with conditional rendering
- Properly formats currency values
- Includes detailed footer with totals
The conditional rendering based on row type ensures that bills and bill items are displayed differently, improving readability.
124-174: Well-structured report header with institutional information.The report header displays:
- Institution name
- Report title with optional department
- Date range information
- Service information when available
The layout is well-organized with appropriate font sizes and spacing.
Summary by CodeRabbit
New Features
Style