Skip to content

11528 remove hardcoded hospital details cc bill wise reports #11529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

buddhika75
Copy link
Member

@buddhika75 buddhika75 commented Apr 2, 2025

Have to set the application option once deployed to production

Footer Text for Collection Centre Bill Wise Detail Report

Summary by CodeRabbit

  • New Features
    • Updated the Collection Centre Bill Wise Detail Report footer to display dynamic content with HTML formatting. This change ensures that payment instructions and contact details are always presented accurately with improved flexibility.

…ove-hardcoded-hospital-details---cc-bill-wise-reports
Now I have to add the value to the production database once the update is deployed in the system
go to institution > manage application options
search for key value pair by the key 'Footer Text for Collection Centre Bill Wise Detail Report'
then use the proper value (html code)
I have saved it in a private document

Signed-off-by: Dr M H Buddhika Ariyaratne <[email protected]>
@buddhika75 buddhika75 linked an issue Apr 2, 2025 that may be closed by this pull request
Copy link
Contributor

coderabbitai bot commented Apr 2, 2025

Walkthrough

The change updates the footer of the collection center bill wise detail report. The previous static footer consisting of multiple paragraph tags has been removed. It is now replaced by a single <h:outputText> component that dynamically retrieves its content by calling the getLongTextValueByKey method on the configOptionApplicationController with the key 'Footer Text for Collection Centre Bill Wise Detail Report'. The dynamic content is allowed to include HTML formatting by setting the escape attribute to false.

Changes

File(s) Changed Summary of Change
src/.../collection_center_bill_wise_detail_report.xhtml Updated footer section: removed multiple <p> elements and replaced them with a single <h:outputText> that calls getLongTextValueByKey('Footer Text for Collection Centre Bill Wise Detail Report') with escape="false".

Sequence Diagram(s)

sequenceDiagram
    participant Page as Report Page
    participant Footer as Footer Component (<h:outputText>)
    participant Controller as ConfigOptionController

    Page ->> Footer: Render footer component
    Footer ->> Controller: getLongTextValueByKey("Footer Text for Collection Centre Bill Wise Detail Report")
    Controller -->> Footer: Return dynamic footer text (HTML enabled)
    Footer -->> Page: Render retrieved footer content
Loading

Possibly related PRs

  • 6735 improvement staff upload #11500: The changes in the main PR, which involve modifying the footer in a report by using a method from configOptionApplicationController, are related to the retrieved PR that introduces ConfigOptionApplicationController as a new dependency in the DataUploadController, indicating a shared focus on this controller.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8d9a629 and ed12d17.

📒 Files selected for processing (1)
  • src/main/webapp/reports/collectionCenterReports/collection_center_bill_wise_detail_report.xhtml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/main/webapp/reports/collectionCenterReports/collection_center_bill_wise_detail_report.xhtml

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@GSMgeeth GSMgeeth merged commit 252589f into development Apr 2, 2025
3 checks passed
@GSMgeeth GSMgeeth deleted the 11528-remove-hardcoded-hospital-details---cc-bill-wise-reports branch April 2, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Hardcoded Hospital Details - CC Bill wise Reports
2 participants