Fixed - need-to-print-custom3-bill-for-ward-direct-issue-to-bht

[damithdeshan98]

closes #11509
Signed-off-by: DamithDeshan [email protected]

Summary by CodeRabbit

• Style
  • Updated date displays to use a more user-friendly format with appropriate timezone adjustments.
  • Refined the presentation of patient details and bill information, including updated labels and additional fields for enhanced clarity and consistency.

[coderabbitai]

Walkthrough

This pull request updates two XHTML files in the pharmacy module. In one file, date-time display for issued and cancelled bills is enhanced by applying a specific timezone and format using <f:convertDateTime>. In the other file, the layout and style of patient and bill details are refined, including changes to labels and the addition of a row for BHT and room number details. No changes were made to underlying logic or exported entities.

Changes

File(s)	Change Summary
src/main/.../pharmacy_transfer_issued_list.xhtml	Added <f:convertDateTime> tags for createdAt and cancelledBill.createdAt fields with timezone "Asia/Colombo" and a dynamic long date/time format from the session controller.
src/main/.../inward_direct_issue_bill_five_five_custom_3.xhtml	Modified layout and label formatting: renamed "Patient Name" to "Name", combined "Age/Sex" display, added a BHT and Room No row, and updated labels for bill date/time, bill no, and department.

Assessment against linked issues

Objective	Addressed	Explanation
Need to print custom3 bill for ward direct issue to BHT (#11509)	✅

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f061f27 and ab66db7.

📒 Files selected for processing (2)

• src/main/webapp/pharmacy/pharmacy_transfer_issued_list.xhtml (1 hunks)
• src/main/webapp/resources/pharmacy/inward_direct_issue_bill_five_five_custom_3.xhtml (1 hunks)

🔇 Additional comments (7)

src/main/webapp/pharmacy/pharmacy_transfer_issued_list.xhtml (2)

69-71: Improved date formatting for better readability

Adding the <f:convertDateTime> tag with the Asia/Colombo timezone and using the application's longDateTimeFormat ensures consistent and localized date display. This enhances readability for users.

---

75-77: Consistent date formatting for cancelled bills

The cancelled bill date is now properly formatted using the same timezone and format as other dates in the application, maintaining consistency in the UI.

src/main/webapp/resources/pharmacy/inward_direct_issue_bill_five_five_custom_3.xhtml (5)

41-48: Simplified label and consistent padding

The label has been simplified from "Patient Name" to just "Name" while adding consistent padding, making the UI cleaner without losing context.

---

51-58: Improved Age/Sex display format

The implementation now uses a more concise format for displaying age and sex information, combining them with a separator and using the appropriate properties (ageAsShortString and sex.label).

---

60-72: Added BHT and Room Number information

This addition of BHT (Bed Head Ticket) and Room Number information is critical for the ward direct issue to BHT functionality mentioned in the PR objectives. This was the main purpose of the PR and properly displays essential patient location information.

---

74-88: Consistent label formatting for date and time

The labels have been updated to remove colons and add consistent padding, improving visual alignment with other labels in the document.

---

90-96: Dynamic department name and consistent formatting

The department is now dynamically displayed from the bill object rather than hardcoded as "Pharmacy". The labels have also been updated for consistency in formatting across the document.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.