Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reconcile Linear - should solve partially #282 #334

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xdecock
Copy link

@xdecock xdecock commented May 21, 2020

Basically,

loops a first time over certificates to create a map name => certs[], this allows for lookup of the possible certificates, which allows way faster matching.

@xdecock
Copy link
Author

xdecock commented May 21, 2020

well the rest of the slowness is linked to that part :

https://github.com/hlandau/acmetool/blob/master/storage/storage-fdb.go#L400

	actualKeyID, err := determineKeyIDFromKey(pk)
	if err != nil {
		return err
	}

Keeping that section solves our 1300 record in ~2Min CPU time, vs 13 seconds, without, i suspect the rand.Reader is the problem here, and can probably lead to entropy starvation on some server.

Could we add a switch to bypass this check?

The PR here, brought our response time down from 35 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant