add support for flash-attention3 #8829
Open
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuangdd01
reviewed
Aug 7, 2025
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| from typing import TYPE_CHECKING | |||
|
|
|||
| from transformers.utils import is_flash_attn_2_available, is_torch_sdpa_available | |||
| from transformers.utils import is_flash_attn_2_available, is_flash_attn_3_available, is_torch_sdpa_available | |||
There was a problem hiding this comment.
We should add a version check here? AFAIK, FA3 utils were introduced recently.
There was a problem hiding this comment.
FA3 was introduced starting from transformers version 4.53.0. Therefore, the dependency on transformers was updated in the requirements.txt file. @Kuangdd01
penfever
pushed a commit
to mlfoundations/LLaMA-Factory
that referenced
this pull request
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for flash attention 3
Fixes # (issue)
#4854