Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option for Horizontal or Vertical Display Orientation #72

Closed
wants to merge 22 commits into from

Conversation

McJackson164
Copy link
Contributor

Hi!
This pull request introduces a new feature that allows users to choose between a horizontal or vertical display orientation.

Changes Implemented:

Config:

  • Added a new setting/config property: G_DISPLAY_ORIENTATION.
  • Added new yaml property: LAYOUT_VERTICAL.
    • Using this property, you can provide one layout for each display orientation.

UI Adjustments:

  • Modified the layout logic to dynamically adjust based on the selected orientation.

Refactor:

  • Change the clear_button label from x to Del

@hishizuka
Copy link
Owner

hishizuka commented May 25, 2024

Please tell me about your environment in which you developed this. Especially display.

@McJackson164
Copy link
Contributor Author

On Windows, so no display yet. My components arrive next week (i.a. ST7789 Display). I will implement the display rotation logic as soon as the components arrive.

@McJackson164 McJackson164 marked this pull request as draft May 25, 2024 15:30
@hishizuka
Copy link
Owner

Please PR the code with the actual display in motion.
It probably won't work in my environment and will need additional modifications.

ST7789, like PiTFT, will no longer be supported.

@McJackson164
Copy link
Contributor Author

Why won't ST7789 displays be supported anymore?

I got it working, but i have to clean the code before i push the changes.
WhatsApp Bild 2024-05-31 um 13 40 32_4e75891f

FYI: I'm using the adafruit_rgb_display library to add another ST7789 implementation. I faced problems using the already added implementation of the ST7789 display when trying to rotate the image.

@McJackson164 McJackson164 marked this pull request as ready for review May 31, 2024 13:35
@hishizuka
Copy link
Owner

Great!

Under what situations would you use this device?
If you plan to use it outdoors for long hours you will be going down the same road I went down 7 years ago.
I think you will suffer from readability under sunlight and poor battery life.
Perhaps you will replace it with a MIP LCD.

I am working on accommodating the new MIP display, which has vertical resolutions, so I will be merging your code over time. I'll be thinking about whether to have a Vertical flag like your code or simply identify it by W and H as I originally thought.

@McJackson164
Copy link
Contributor Author

Yes, i will use it outdoors. A MIP display sounds reasonable.

Okay, great!

@hishizuka
Copy link
Owner

hishizuka commented Jun 7, 2024

Tell me the connection pin between TFT and Raspberry Pi.
Others can not run your code.

@McJackson164
Copy link
Contributor Author

ST7789_Breakout_Circuit

Are there any thrown errors/warnings? Maybe i can help

@hishizuka
Copy link
Owner

Hi, @McJackson164

Sorry, when I try to implement the vertical layout feature, I can't incorporate all of your PRs because your and my implementation policies are very different. (Lack of consideration when resizing, i.e., cannot support different resolutions).

st7789_breakout_display.py is available for import, so please PR this source only.

@hishizuka hishizuka closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants