-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Route to Fetch Blocks by Tenure Height #2144
Open
bowtiedbot
wants to merge
1
commit into
hirosystems:develop
Choose a base branch
from
degen-lab:feat/get-blocks-by-tenure-height
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+132
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
import { handleChainTipCache } from '../../controllers/cache-controller'; | ||
import { parseDbNakamotoBlock } from './helpers'; | ||
import { TenureParamsSchema } from './schemas'; | ||
import { InvalidRequestError, NotFoundError } from '../../../errors'; | ||
import { FastifyPluginAsync } from 'fastify'; | ||
import { Type, TypeBoxTypeProvider } from '@fastify/type-provider-typebox'; | ||
import { Server } from 'node:http'; | ||
import { LimitParam, OffsetParam } from '../../schemas/params'; | ||
import { ResourceType } from '../../pagination'; | ||
import { PaginatedResponse } from '../../schemas/util'; | ||
import { NakamotoBlockSchema } from '../../schemas/entities/block'; | ||
|
||
export const TenureHeightRoutesV2: FastifyPluginAsync< | ||
Record<never, never>, | ||
Server, | ||
TypeBoxTypeProvider | ||
> = async fastify => { | ||
fastify.get( | ||
'/:height/blocks', | ||
{ | ||
preHandler: handleChainTipCache, | ||
schema: { | ||
operationId: 'get_blocks_by_tenure_height', | ||
summary: 'Get blocks by tenure height', | ||
description: `Retrieves a list of blocks confirmed within a specific tenure height`, | ||
tags: ['Tenure Height'], | ||
params: TenureParamsSchema, | ||
querystring: Type.Object({ | ||
limit: LimitParam(ResourceType.TenureHeight), | ||
offset: OffsetParam(), | ||
}), | ||
response: { | ||
200: PaginatedResponse(NakamotoBlockSchema), | ||
}, | ||
}, | ||
}, | ||
async (req, reply) => { | ||
const { height } = req.params; | ||
const query = req.query; | ||
|
||
try { | ||
const { limit, offset, results, total } = await fastify.db.v2.getBlocksByTenureHeight({ | ||
height, | ||
...query, | ||
}); | ||
const blocks = results.map(r => parseDbNakamotoBlock(r)); | ||
await reply.send({ | ||
limit, | ||
offset, | ||
total, | ||
results: blocks, | ||
}); | ||
} catch (error) { | ||
if (error instanceof InvalidRequestError) { | ||
throw new NotFoundError(error.message); | ||
} | ||
throw error; | ||
} | ||
} | ||
); | ||
|
||
await Promise.resolve(); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For v2 endpoints we're trying to keep route names as REST-ful as possible, so we want to group endpoints according to the entity that they return. Adding
tenure-height
here would not fit the standard.Could you instead add a
tenure_height
query param to the/extended/v2/blocks
endpoint? That will also allow you to get cursor pagination for free and will work much better with API clients.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rafaelcr! I am currently trying to modify the query from pg-store-v2, but when parsing a tenure height query, the results list is empty. Can you please take a look over it and let me know what I'm doing wrong? Thank you!
https://github.com/degen-lab/stacks-blockchain-api/blob/test/get-blocks-by-tenure-height/src/datastore/pg-store-v2.ts#L76-L140