feat: improve insert nft custody #1880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bestmike007 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
Did the error you reported on the other PR go away after this change @bestmike007 ? At first glance, it looks like this change wouldn't do much because we already remove duplicate rows per each batch run, however I'm curious to see if this made any change for you. Perhaps there's something else we're missing here. |
|
Closing due to inactivity. If this is still an issue, please reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to prevent upsert the same row in table
nft_custodyduringupdateNftEventsType of Change
Does this introduce a breaking change?
No.
Are documentation updates required?
No.
Testing information
No, all covered.
Checklist
npm run testpasses