Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve insert nft custody #1880

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bestmike007
Copy link
Contributor

Description

This PR is to prevent upsert the same row in table nft_custody during updateNftEvents

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

Does this introduce a breaking change?

No.

Are documentation updates required?

No.

Testing information

No, all covered.

Checklist

  • Code is commented where needed
  • Unit test coverage for new or modified code paths
  • npm run test passes
  • Changelog is updated
  • Tag 1 of @rafaelcr or @zone117x for review

@bestmike007
Copy link
Contributor Author

@rafaelcr @zone117x

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.86%. Comparing base (7921488) to head (e785a6c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1880      +/-   ##
==========================================
- Coverage   71.86%   71.86%   -0.01%     
==========================================
  Files          92       92              
  Lines       11911    11914       +3     
  Branches     2624     2624              
==========================================
+ Hits         8560     8562       +2     
- Misses       3197     3198       +1     
  Partials      154      154              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bestmike007 bestmike007 changed the base branch from develop to master March 6, 2024 09:29
@rafaelcr
Copy link
Collaborator

rafaelcr commented Mar 6, 2024

Did the error you reported on the other PR go away after this change @bestmike007 ? At first glance, it looks like this change wouldn't do much because we already remove duplicate rows per each batch run, however I'm curious to see if this made any change for you. Perhaps there's something else we're missing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants