Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: newest unconfirmed block propsal metric #71

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

rafaelcr
Copy link
Collaborator

Rename the signer_api_time_since_last_pending_block_proposal_ms to be signer_api_time_since_newest_pending_block_proposal_ms, and keep the old functionality as signer_api_time_since_oldest_pending_block_proposal_ms

Copy link

Vercel deployment URL: https://signer-metrics-cqh5jiahs-hirosystems.vercel.app 🚀

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever solution, I like it. Thanks! :shipit:

@rafaelcr rafaelcr merged commit cb4b117 into main Jan 27, 2025
5 checks passed
@rafaelcr rafaelcr deleted the fix/last-proposal branch January 27, 2025 16:57
blockstack-devops pushed a commit that referenced this pull request Jan 27, 2025
## [0.12.6](v0.12.5...v0.12.6) (2025-01-27)

### Bug Fixes

* newest unconfirmed block propsal metric ([#71](#71)) ([cb4b117](cb4b117))
@blockstack-devops
Copy link

🎉 This PR is included in version 0.12.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants