feat: tabs #2017
feat: tabs #2017
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
src/ui/theme/recipes/TabsRecipe.ts
Outdated
| fontWeight: 'regular', | ||
| }, | ||
| }, | ||
| xlg: { |
There was a problem hiding this comment.
typically this is written xl. we use this nomenclature elsewhere so we should use the same here
src/ui/theme/recipes/TabsRecipe.ts
Outdated
| fontWeight: 'regular', | ||
| }, | ||
| }, | ||
| xxlg: { |
|
It looks like you needed to specify the tabs implementation use ark tabs. Is it correct to assume that there is a bug with Chakra UI's implementation and the exports it provides? |
Ark is ChakraUI's headless UI framework that they use under the hood, I've seen it being used in ChakraUI's custom recipes and it seems to have more granular options and better type exports. I think we can make it work without it though. |
|
🎉 This PR is included in version 1.253.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What type of PR is this? (check all applicable)
Description
Issue ticket number and link
closes: #2008
Checklist:
Screenshots (if appropriate):