-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/table #2003
base: main
Are you sure you want to change the base?
Feat/table #2003
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
514cf74
to
b06e1ed
Compare
1b7a47e
to
072a607
Compare
Thanks for putting this together, Nick! In my experience, large monolithic components like this table can be tough to maintain and not flexible enough to accommodate future changes. I’d suggest breaking this down into smaller, composable parts for the different variations of filters or rows. That would make it easier to extend and also much simpler to review. |
Hey Andy, thanks for the review. Can you please be more specific about which parts of the table is monolithic in nature? I agree that the table implementation should be as composable and flexible as possible to support multiple table variations, and this is what I set out to do in this PR. In this PR, I have not implemented any table filters yet. From the way that I am thinking about the table so far, I don't think that any table filter logic added here on out would need to be part of the core table code. The implementation of the row rendering logic is not contained inside the table. The table accepts a column defintion array in which table consumers specify what their columns look like, inlcuding a cellrenderer function, which tells the table how to render the cells in the column. In the table examples directory, you can see src/common/components/table/table-examples/TxTableCellRenderers.tsx. That file shows that all the logic required to rendering a particular tables rows/columns is independent from the underlying table code. |
54d1365
to
efb6f63
Compare
efb6f63
to
2f1e50e
Compare
2f1e50e
to
8cf16e2
Compare
@BLuEScioN I added my comments on Storybook Two things I didn't revise because I didn't know if they were ready for review:
![]() ![]() |
I did implement the empty state. As we discussed, we are not adding the ripple styles that you have in figma. Note that I did change the text that you had from "This account has no transactions yet." to "No results found". I did this because "This account has no transactions yet." might only apply to account pages, where as "No results found" is more general. The text is configurable in the code. Yes the responsive styles are ready to review, for the table. This PR is only trying to implement the table designs. The only reason that I have the tx table 90% implemented is because I needed to see if the table was capable of working for our intended use cases. It would be best to use the simple table to provide feedback for this PR |
Empty state:
![]() ![]() Responsiveness: @andresgalante Since these PRs share the same name as the designs and reference them, it might be helpful to note in the PRs what is not included or will be addressed later. This way, I can avoid annotating missing elements unnecessarily. |
Approving and noting here what's not included in this PR for future reference:
|
What type of PR is this? (check all applicable)
Description
Adds the table component for our design system.
This PR will be followed by PRs for the additions to the table component:
NB: I included a TxsTable component as I was writing that to sanity check my implementation worked and I was using it in the table storybook. None of this is going to be shown anyway so I'd prefer to just leave that component in this PR, as I will be using it pretty soon in a follow up PR for the txs page
To check the table implementation, please check out the storybook deployment link. There are a lot of table configurations available in the storybook control panel
Issue ticket number and link
#1995
#1996
#1998
Checklist:
Screenshots (if appropriate):