fix: make sbtc funding on devnet more robust #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
hugocaillard
commented
Feb 28, 2025
| @@ -817,14 +815,23 @@ fn fund_genesis_account( | |||
|
|
|||
| let _ = hiro_system_kit::thread_named("sBTC funding handler").spawn(move || { | |||
| while !boot_completed_moved.load(Ordering::SeqCst) { | |||
| std::thread::sleep(std::time::Duration::from_secs(1)); | |||
| std::thread::sleep(std::time::Duration::from_secs(3)); | |||
There was a problem hiding this comment.
This is probably not bullet prof, but I found 3 seconds to work reliably
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous logic was picking an arbitrary bitcoin block as an argument to pass to the mint call.
It was very likely that whatever this height was, it was skipped (because a lot of bitcoin blocks are skipped around epoch 3.0 switch).
The PR just takes the latest bitcoin block, instead of an arbitrary one