Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Windows file path handling #1648

Closed

Conversation

tippenein
Copy link
Collaborator

fixes #1634

I need to test this on a windows machine, but I believe if we normalize the windows format before getting the path we should be ok. Added some tests which may be useful..

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tippenein
❌ brady.ouren


brady.ouren seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tippenein
Copy link
Collaborator Author

Sorry, this was on my fork because I opened the branch from github ui on windows initially

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
components/clarinet-files/src/lib.rs 92.85% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@tippenein
Copy link
Collaborator Author

closing for #1649

@tippenein tippenein closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Absolute manifest path cannot be used to initialize a simnet session on Windows
2 participants