Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support stacks.js v7 #1605

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: support stacks.js v7 #1605

wants to merge 3 commits into from

Conversation

hugocaillard
Copy link
Collaborator

Description

Update the clarinet js sdk to use stacks.js 7 and vitest 2

This PR introduces breaking changes in the sdk, the release strategy is tbd, either:

  • release the clarinet sdk as 3.x but decouple it from clarinet versionning (and keep the cli as 2.x), would make sense but bring a bit of confusion
  • break semver an release as 2.x, not ideal

@hugocaillard hugocaillard requested a review from janniks October 30, 2024 18:42
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
components/clarinet-cli/src/generate/project.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hugocaillard hugocaillard marked this pull request as draft February 11, 2025 08:29
@pradel
Copy link

pradel commented Feb 11, 2025

release the clarinet sdk as 3.x but decouple it from clarinet versionning (and keep the cli as 2.x), would make sense but bring a bit of confusion

Making clarinet and the SDK have the same version is nice, what's the issue with releasing this as clarinet v3?

@hugocaillard hugocaillard changed the title Feat/stacks.js v7 feat: support stacks.js v7 Feb 11, 2025
@hugocaillard hugocaillard mentioned this pull request Feb 11, 2025
13 tasks
@hugocaillard
Copy link
Collaborator Author

Making clarinet and the SDK have the same version is nice, what's the issue with releasing this as clarinet v3?

Some people can expext major updates or new features from a new major version.
And for developers to upgrade (and adapt to breaking changes), they have to find some value in it.

But we are doing it. Here is (almost) everything that will be included in 3.0: #1672
cc @pradel

janniks
janniks previously approved these changes Feb 19, 2025
Copy link
Contributor

@janniks janniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👏 Functional, clean!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In Progress
Development

Successfully merging this pull request may close these issues.

3 participants