Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: async fs operations #676

Open
wants to merge 2 commits into
base: feat/reregister-callback
Choose a base branch
from

Conversation

zone117x
Copy link
Member

Replaces the sync node:fs operations with async node:fs/promises async operations. This fixes potential issues with the main program loop completely blocking while waiting on disk operations. E.g. sync disk operations causing lots of small pauses/delays while serving http requests.

@zone117x zone117x requested a review from rafaelcr October 31, 2024 15:50
@zone117x zone117x changed the base branch from stacks-signers to feat/reregister-callback October 31, 2024 15:50
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

2 participants