Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: callback to intercept and modify predicates before re-registration #675

Open
wants to merge 2 commits into
base: stacks-signers
Choose a base branch
from
Open

feat: callback to intercept and modify predicates before re-registration #675

wants to merge 2 commits into from

Conversation

zone117x
Copy link
Member

Closes #674

  • First commit adds an optional callback that clients can use to modify an inactive predicate before it is re-registered.
  • Second commit fixes an issue where the the setInterval could result in overlapping healthcheck code running if something like the callback (which could be waiting on a postgres connection, for example) take a long time.

@zone117x zone117x requested a review from rafaelcr October 31, 2024 15:47
@zone117x zone117x had a problem deploying to Development-mainnet October 31, 2024 15:55 — with GitHub Actions Failure
@zone117x zone117x had a problem deploying to Development-testnet October 31, 2024 15:55 — with GitHub Actions Failure
rafaelcr
rafaelcr approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelcr rafaelcr rafaelcr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Status: 👀 In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zone117x @rafaelcr