Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display unbound inscription satpoints as all zeros with unbound sequence as offset #445

Merged
merged 8 commits into from
Feb 21, 2025

Conversation

rafaelcr
Copy link
Collaborator

Changes the indexing logic of unbound inscriptions (those sent as fees to miners) in order to assign them an all-zero satpoint location instead of trying to calculate where in the coinbase transaction ordinals they fall.

This makes our unbound transaction display be consistent with ordinals dot com.

Fixes #438

@rafaelcr rafaelcr requested a review from ASuciuX February 21, 2025 03:30
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
components/ordhook-core/src/db/ordinals_pg.rs 66.66% 4 Missing ⚠️
.../ordhook-core/src/core/protocol/sequence_cursor.rs 84.61% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@rafaelcr rafaelcr requested a deployment to Development-mainnet-blue February 21, 2025 03:51 — with GitHub Actions Waiting
Copy link
Contributor

@ASuciuX ASuciuX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaelcr rafaelcr merged commit 6815878 into develop Feb 21, 2025
12 of 14 checks passed
@rafaelcr rafaelcr deleted the fix/unbound branch February 21, 2025 15:31
github-actions bot pushed a commit that referenced this pull request Feb 25, 2025
## [3.0.0-beta.11](v3.0.0-beta.10...v3.0.0-beta.11) (2025-02-25)

### Bug Fixes

* **brc20:** historical token balance ([#444](#444)) ([41438ac](41438ac))
* display unbound inscription satpoints as all zeros with unbound sequence as offset ([#445](#445)) ([6815878](6815878))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

report unbound inscription locations as zeros
2 participants