fix: isFinished never set on waiter (#35)

hirosystems · Mar 5, 2025 · 9c1d2b3 · 9c1d2b3
1 parent 379dc9b
commit 9c1d2b3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/helpers/__tests__/helpers.test.ts b/src/helpers/__tests__/helpers.test.ts
@@ -1,5 +1,5 @@
 import * as events from 'node:events';
-import { timeout } from '../time';
+import { timeout, waiter } from '../time';
 
 describe('Helper tests', () => {
   test('timeout function should not cause memory leak by accumulating abort listeners on abort', async () => {
@@ -49,4 +49,11 @@ describe('Helper tests', () => {
     // Final check to confirm listeners are cleaned up
     expect(countListeners()).toBe(0);
   });
+
+  test('waiter is finished', async () => {
+    const myWaiter = waiter();
+    myWaiter.finish();
+    await myWaiter;
+    expect(myWaiter.isFinished).toBe(true);
+  });
 });
diff --git a/src/helpers/time.ts b/src/helpers/time.ts
@@ -121,7 +121,7 @@ export function waiter<T = void>(): Waiter<T> {
   });
   const completer = {
     finish: (result: T) => {
-      completer.isFinished = true;
+      void Object.assign(promise, { isFinished: true });
       resolveFn(result);
     },
     isFinished: false,