Skip to content

Commit

Permalink
fix env name for gitlab token (#24)
Browse files Browse the repository at this point in the history
  • Loading branch information
hirosassa authored Oct 26, 2022
1 parent 8a46f86 commit 3b063b9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ The comment posted by ksnotify is as follows:
Create and export GitLab access token to environmental variables as follows:

```console
export GITLAB_TOKEN="xxxxxx"
export KSNOTIFY_GITLAB_TOKEN="xxxxxx"
```
ref: [Project access tokens | GitLab](https://docs.gitlab.com/ee/user/project/settings/project_access_tokens.html)

Expand All @@ -64,8 +64,8 @@ Basic usage is as follows:
skaffold render -p dev | kubectl diff -f - 2> /dev/null | | ksnotify --notifier gitlab --ci gitlab
```

To suppress `skaffold` labels like `skaffold.dev/run-id: 1234` automatically added by `skaffold`, you should declare
To suppress `skaffold` labels like `skaffold.dev/run-id: 1234` automatically added by `skaffold`, you should add `--suppress-skaffold` flag like

```console
export KSNOTIFY_SUPPRESS_SKAFFOLD=1
skaffold render -p dev | kubectl diff -f - 2> /dev/null | | ksnotify --notifier gitlab --ci gitlab --suppress-skaffold
```
2 changes: 1 addition & 1 deletion src/notifier/gitlab.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use std::env;

use super::Notifiable;

const ENV_GITLAB_TOKEN: &str = "GITLAB_TOKEN";
const ENV_GITLAB_TOKEN: &str = "KSNOTIFY_GITLAB_TOKEN";

#[derive(Debug)]
pub struct GitlabNotifier {
Expand Down

0 comments on commit 3b063b9

Please sign in to comment.