Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support config-file #154

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

support config-file #154

wants to merge 3 commits into from

Conversation

lazychanger
Copy link

#93

@lazychanger
Copy link
Author

@estahn
i fixed issue #93 , please help me review the code

@itcsoft54
Copy link
Contributor

Please check if ENV is prior to values in configuration file.
If not it can break the way that debian package Prometheus export (using /etc/default/<name_exporter>.conf file for parameters) that currently use ENV prior to configuration to redefine value.
Conf file seem to be load after env variables loaded, in case of define both in ENV and conf file.

@lazychanger
Copy link
Author

Please check if ENV is prior to values in configuration file.
If not it can break the way that debian package Prometheus export (using /etc/default/<name_exporter>.conf file for parameters) that currently use ENV prior to configuration to redefine value.
Conf file seem to be load after env variables loaded, in case of define both in ENV and conf file.

I think ENV has a higher weight than files. so you can see use mapEnvVars to override the file configuration.
My english for Google Transfer. Please don't mind.
Thanks for you review.

@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants