Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for < 24 hours #42

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Fix for < 24 hours #42

merged 1 commit into from
Aug 2, 2024

Conversation

AaronJackson
Copy link
Member

No description provided.

@AaronJackson AaronJackson requested a review from manics August 1, 2024 10:11
@AaronJackson
Copy link
Member Author

i'm sure it was working when i originally tested it

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we could consider adding tests https://devblogs.microsoft.com/scripting/unit-testing-powershell-code-with-pester/
e.g. Record a real return value of quser and verify the rest of the logic works. If it breaks in future we'd know it's probably due to change in the object.

@AaronJackson AaronJackson merged commit 0305865 into main Aug 2, 2024
6 checks passed
@AaronJackson AaronJackson deleted the quserhmmm branch August 2, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants