Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Discounts by default, release version 0.2.0 #6

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Exclude Discounts by default, release version 0.2.0 #6

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c9d091
Exclude `Enterprise Discount Program Discount` and `Solution Provider…
manics May 14, 2024
4109d00
Update comment about undocumented discount record types
manics Jun 13, 2024
2dc1fe5
Add 0.2.0 changelog
manics Jun 13, 2024
6830551
0.2.0 date: 2024-06-18
manics Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## 0.2.0 - 2024-06-16
manics marked this conversation as resolved.
Show resolved Hide resolved

### Breaking

- Add `Enterprise Discount Program Discount` and `Solution Provider Program Discount` to the list of default excluded record types [#6](https://github.com/hic-infra/hic-aws-costing-tools/pull/6).
To revert to the previous behaviour pass `--exclude-types Credit Refund Tax`

## 0.1.0 - 2024-04-24

Release 0.1.0
Expand Down
11 changes: 10 additions & 1 deletion hic_aws_costing_tools/aws_costs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,16 @@

DEFAULT_COST_TYPE = "UnblendedCost"
DEFAULT_GRANULARITY = "MONTHLY"
DEFAULT_EXCLUDE_RECORD_TYPES = ["Credit", "Refund", "Tax"]
DEFAULT_EXCLUDE_RECORD_TYPES = [
"Credit",
"Refund",
"Tax",
# These two aren't documented on
# https://docs.aws.amazon.com/awsaccountbilling/latest/aboutv2/manage-cost-categories.html#cost-categories-terms
# but were confirmed in AWS Support ticket 171570162800825
"Enterprise Discount Program Discount",
"Solution Provider Program Discount",
]
EXPECTED_UNIT = "USD"


Expand Down
Loading