Skip to content

Commit

Permalink
Merge pull request #10 from manics/dev
Browse files Browse the repository at this point in the history
Add changelog for 1.0.0, add pre-commit
  • Loading branch information
manics authored Nov 22, 2023
2 parents 214a20c + 88a692b commit fa0bb7b
Show file tree
Hide file tree
Showing 8 changed files with 38 additions and 12 deletions.
18 changes: 10 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,28 +1,30 @@
---

name: CI
on:
push:
pull_request:

jobs:

validate:
name: terraform validate
runs-on: ubuntu-latest
name: terraform lint and validate
runs-on: ubuntu-22.04
timeout-minutes: 4
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install terraform
uses: hashicorp/setup-terraform@v2

- uses: actions/setup-python@v4
with:
python-version: "3.11"

- name: Validate
run: |
cd ecs-cluster
terraform init -backend=false
terraform validate
- name: Lint
run: |
terraform fmt -recursive --diff -check
- name: pre-commit
uses: pre-commit/[email protected]
1 change: 0 additions & 1 deletion .github/workflows/container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ env:
PLATFORMS: linux/amd64,linux/arm64

jobs:

container-build:
runs-on: ubuntu-latest
steps:
Expand Down
17 changes: 17 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
repos:
- repo: https://github.com/pre-commit/mirrors-prettier
rev: v3.1.0
hooks:
- id: prettier
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.4.0
hooks:
- id: trailing-whitespace
- id: end-of-file-fixer
- id: check-json
- id: check-yaml
- repo: https://github.com/antonbabenko/pre-commit-terraform
rev: v1.83.6
hooks:
- id: terraform_fmt
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Keycloak on ECS with RDS

[![CI](https://github.com/hic-infra/ecs-keycloak/actions/workflows/ci.yml/badge.svg)](https://github.com/hic-infra/ecs-keycloak/actions/workflows/ci.yml)
[![Container build](https://github.com/manics/ecs-keycloak/actions/workflows/container.yml/badge.svg)](https://github.com/manics/ecs-keycloak/actions/workflows/container.yml)

Expand Down Expand Up @@ -27,6 +28,7 @@ Create an S3 backend configuration file (see [`ecs-cluster/example.s3.tfbackend`
Check the [Terraform variables](ecs-cluster/variables.tf), and define them in a `*.tfvars` file, e.g. `example.tfvars`.

Initialise the terraform directory passing (first time only), then run:

```sh
cd ecs-cluster
terraform init -backend-config=example.s3.tfbackend
Expand Down
7 changes: 7 additions & 0 deletions ecs-cluster/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Changelog

## 1.0.0 - 2023-11-23

First full release

- Keycloak 22.05
2 changes: 1 addition & 1 deletion ecs-cluster/keycloak.tf
Original file line number Diff line number Diff line change
Expand Up @@ -366,4 +366,4 @@ resource "aws_ecs_service" "keycloak" {
# lifecycle {
# ignore_changes = [desired_count]
# }
}
}
2 changes: 1 addition & 1 deletion ecs-cluster/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ output "dnsname" {

output "keycloak-initial-password" {
value = random_string.initial-keycloak-password.result
}
}
1 change: 0 additions & 1 deletion ecs-cluster/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,3 @@ terraform {

required_version = ">= 1.5.0"
}

0 comments on commit fa0bb7b

Please sign in to comment.