Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HHH-18132 Add support for skip locked for HANA #8396

Merged
merged 4 commits into from
May 21, 2024
Merged

HHH-18132 Add support for skip locked for HANA #8396

merged 4 commits into from
May 21, 2024

Conversation

fmusolino
Copy link
Contributor

@fmusolino fmusolino commented May 17, 2024 •
edited by hibernate-github-bot bot

@beikov beikov added the hana label May 17, 2024
@fmusolino fmusolino force-pushed the HHH-18132 branch 3 times, most recently from d49807d to 79e88ee Compare May 17, 2024 16:17
@fmusolino
Copy link
Contributor Author

Corrected the issue with the string returned by getSkipLocked not containing the heading space and added an implementation for getForUpdateSkipLockedString in AbstractHANADialect.
Still have to fix a problem with the version detection, so leaving this in draft for now.

@fmusolino
Copy link
Contributor Author

Hello there,
I'm really sorry but I had some real life issues and I won't be be at my computer at least until tomorrow night, so I won't be able to make progress this weekend. I should be able to finish developing this on Monday tho.

@fmusolino fmusolino marked this pull request as ready for review May 20, 2024 07:13
@fmusolino
Copy link
Contributor Author

I fixed the issue with the version detection (which was caused by a misunderstanding of mine in how HANA version numbering works). My own tests had a positive result, so I'm putting this in ready for review.

@fmusolino
Copy link
Contributor Author

Will take a look at the failing tests as soon as I get home from work

@beikov
Copy link
Contributor

beikov commented May 21, 2024

Don't worry about these test failures, those are different errors. Your PR is fine. Thanks.

@beikov beikov merged commit c198fcf into hibernate:main May 21, 2024
23 of 26 checks passed
@fmusolino
Copy link
Contributor Author

Thank you so much! It's actually my first time I submit a pull request for an open source project so I'm very glad this went smoothly. Thanks again.

@beikov
Copy link
Contributor

beikov commented May 23, 2024

Thanks for your contribution. Looking forward to your next one ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beikov beikov beikov approved these changes

Assignees
No one assigned
Labels
hana
Projects
None yet
Milestone
No milestone
2 participants
@fmusolino @beikov