Added Favicon #171
Open
Added Favicon #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know it's a small thing, but this package had no favicon. As a result, it didn't have a little icon in my browser bar and didn't have an icon if I bookmarked it. I used an online favicon generator to make up a little icon. The original is in
html/img/mineos.png. This PR adds a bunch of image files for the icon in various formats and then the HTML metadata to make it work on lots of browsers. It's a bit of overkill, since I'm not sure how many people are using the web UI from Android phones or Windows desktops. But it's sorta trivial to support them. Hope this is helpful.