-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove alias json for support add custom language support #414
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Mimi <[email protected]>
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about still preferring the alias, but even if the existing alias doesn't match, then use the hljs.getLanguage
as a fallback? This prevents unexpected behavior changes.
You are right, I already fix it. btw: many useless commit, use squash merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. What do you think? @hexojs/core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yutingzhao1991
Would you please fix lint errors? Other than that, LGTM.
check list
Description
use
hljs.getLanguage
for check language support, so I can add new language support with hexo plugin.Additional information
for hexojs/hexo#5639