Flags :D #60
Open
Flags :D #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
object-Object
requested changes
Jan 2, 2024
Comment on lines
+3
to
+5
| <section id="{{ category.id.path }}" class="{% if category.flag is not none %} | ||
| {{ category.flag.css_classnames() }} | ||
| {% endif %}"> |
There was a problem hiding this comment.
Suggested change
| <section id="{{ category.id.path }}" class="{% if category.flag is not none %} | |
| {{ category.flag.css_classnames() }} | |
| {% endif %}"> | |
| <section id="{{ category.id.path }}" class="{{ category.flag.css_classnames() if category.flag }}"> |
There was a problem hiding this comment.
(this is also helpful because the current code adds extra newlines to the output, as you can see in the snapshots)
| @@ -1,6 +1,9 @@ | |||
| {% import "macros/formatting.html.jinja" as fmt -%} | |||
|
|
|||
| <div id="{{ entry.id.path }}" class="entry"> | |||
| <div id="{{ entry.id.path }}" class="entry | |||
| @@ -3,7 +3,9 @@ | |||
| {% set page_anchor_id = entry.id.path ~ "@" ~ page.anchor %} | |||
|
|
|||
| {#- page content (not required because EmptyPage uses this template directly) #} | |||
| <div id="{{ page_anchor_id }}"> | |||
| <div id="{{ page_anchor_id }}" class="{% if entry.flag is not none %} | |||
Comment on lines
+16
to
+18
| assert ( | ||
| "," not in data | ||
| ) # not sure if there are other invalid characters or not |
There was a problem hiding this comment.
- what's this for?
- move the comment to the line above and it'll be formatted a bit less weirdly
- this should have some sort of useful error message, not just an empty assert (ie.
assert condition, "message goes here")
| @model_validator(mode="before") | ||
| @classmethod | ||
| def parse_flag(cls, data: Any) -> Any: | ||
| if isinstance(data, str): |
There was a problem hiding this comment.
nit: I'd probably do a match statement, but this works too
Comment on lines
+40
to
+45
| if data.startswith("|") or data.startswith("&"): # must be a list | ||
| return { | ||
| "flags": data[1:].split(","), | ||
| "conjuctive": data.startswith("&"), | ||
| } | ||
| return {"flags": [data]} |
There was a problem hiding this comment.
these could (and probably should) return instances of the class instead of dicts. for example: return cls(flags=[data])
| @@ -184,7 +184,8 @@ | |||
| title="Permalink" | |||
| ><i class="bi bi-link-45deg"></i></a></h2> | |||
| <p>The practitioners of this art would cast their so-called <span style="color: #b38ef3">Hexes</span> by drawing strange patterns in the air with a <a href="GITHUB_PAGES_URL/v/latest/main/en_us#items/staff"><span style="color: #b0b">Staff</span></a> -- or craft <a href="GITHUB_PAGES_URL/v/latest/main/en_us#items/hexcasting"><span style="color: #b0b">powerful magical items</span></a> to do the casting for them. How might I do the same?</p> | |||
| <div id="baz" class="entry"> | |||
| <div id="baz" class="entry | |||
There was a problem hiding this comment.
(this is what i mentioned above)
|
@SamsTheNerd are you still interested in getting this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
didn't bother adding the test flags into the nox stuff, not sure if that'll effect the snapshots ?