feat: Copy NGPG credentials' commands (W-20611052) #3522
Merged
+2,213
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Here we copy the
data:pg:credentialstopic commands from NGPG plugin to Core CLI v11 with tests, refactoring everything for ESM and@oclif/corev4.There are no functional changes besides small refactorings to make the coloring scheme for
data:pg:...commands consistent.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
All NGPG commands have been extensively tested on the plugin implementations. But it's recommended that at least you download this branch, run
npm install && npm run buildand proceed to minimally test the involved commands:./bin/run data:pg:credentials <DATABASE-NAME> -a <test-app>./bin/run data:pg:credentials:create <DATABASE-NAME> -a <test-app> --name <credential-name>./bin/run data:pg:credentials:destroy <DATABASE-NAME> -a <test-app> --name <credential-name> --confirm <test-app>./bin/run data:pg:credentials:rotate <DATABASE-NAME> -a <test-app>./bin/run data:pg:credentials:url <DATABASE-NAME> -a <test-app>A caveat that
<DATABASE-NAME>needs to be an Advanced-tier database or an error will be returned for most commands. Use./bin/run data:pg:createto create the required database if you don't have one test database readily at hand for testing.Related Issues
GUS work item: W-20611052