Skip to content

Conversation

@sbosio
Copy link
Contributor

@sbosio sbosio commented Feb 10, 2026

Summary

Here we copy the data:pg:credentials topic commands from NGPG plugin to Core CLI v11 with tests, refactoring everything for ESM and @oclif/core v4.

There are no functional changes besides small refactorings to make the coloring scheme for data:pg:... commands consistent.

Type of Change

Breaking Changes (major semver update)

  • Add a ! after your change type to denote a change that breaks current behavior

Feature Additions (minor semver update)

  • feat: Introduces a new feature to the codebase

Patch Updates (patch semver update)

  • fix: Bug fix
  • deps: Dependency upgrade
  • revert: Revert a previous commit
  • chore: Change that does not affect production code
  • refactor: Refactoring existing code without changing behavior
  • test: Add/update/remove tests

Testing

All NGPG commands have been extensively tested on the plugin implementations. But it's recommended that at least you download this branch, run npm install && npm run build and proceed to minimally test the involved commands:

  • ./bin/run data:pg:credentials <DATABASE-NAME> -a <test-app>
  • ./bin/run data:pg:credentials:create <DATABASE-NAME> -a <test-app> --name <credential-name>
  • ./bin/run data:pg:credentials:destroy <DATABASE-NAME> -a <test-app> --name <credential-name> --confirm <test-app>
  • ./bin/run data:pg:credentials:rotate <DATABASE-NAME> -a <test-app>
  • ./bin/run data:pg:credentials:url <DATABASE-NAME> -a <test-app>

A caveat that <DATABASE-NAME> needs to be an Advanced-tier database or an error will be returned for most commands. Use ./bin/run data:pg:create to create the required database if you don't have one test database readily at hand for testing.

Related Issues

GUS work item: W-20611052

@sbosio sbosio requested a review from a team as a code owner February 10, 2026 19:14
Copy link
Contributor

@tlowrimore-heroku tlowrimore-heroku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbosio sbosio merged commit 97703da into v11.0.0 Feb 10, 2026
13 checks passed
@sbosio sbosio deleted the sbosio/ngpg-credentials branch February 10, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants