Skip to content

Conversation

@sbosio
Copy link
Contributor

@sbosio sbosio commented Feb 9, 2026

Summary

Here we introduce new commands copied from the NGPG plugin for the data:pg:attachments and data:pg:quotas topics' commands, including tests.

Minor refactorings were done to convert to ESM and @oclif/core v4.

Type of Change

Breaking Changes (major semver update)

  • Add a ! after your change type to denote a change that breaks current behavior

Feature Additions (minor semver update)

  • feat: Introduces a new feature to the codebase

Patch Updates (patch semver update)

  • fix: Bug fix
  • deps: Dependency upgrade
  • revert: Revert a previous commit
  • chore: Change that does not affect production code
  • refactor: Refactoring existing code without changing behavior
  • test: Add/update/remove tests

Testing

All NGPG commands have been extensively tested on the plugin implementations. But it's recommended that at least you download this branch, run npm install && npm run build and proceed to minimally test the involved commands:

  • ./bin/run data:pg:attachments <DATABASE-NAME> -a <test-app>
  • ./bin/run data:pg:attachments:create <DATABASE-NAME> -a <test-app> --as <ATTACHMENT-NAME>
  • ./bin/run data:pg:attachments:destroy <ATTACHMENT-NAME> -a <test-app> --confirm <test-app>
  • ./bin/run data:pg:quotas <DATABASE-NAME> -a <test-app>
  • ./bin/run data:pg:quotas:update <DATABASE-NAME> -a <test-app> --type storage --critical 200

A caveat that <DATABASE-NAME> needs to be an Advanced-tier database or an error will be returned for most commands. Use ./bin/run data:pg:create to create the required database if you don't have one test database readily at hand for testing.

Related Issues

GUS work item: W-20611041

@sbosio sbosio requested a review from a team as a code owner February 9, 2026 17:04
@sbosio sbosio temporarily deployed to AcceptanceTests February 9, 2026 18:05 — with GitHub Actions Inactive
@sbosio sbosio temporarily deployed to AcceptanceTests February 9, 2026 18:05 — with GitHub Actions Inactive
@sbosio sbosio temporarily deployed to AcceptanceTests February 9, 2026 18:05 — with GitHub Actions Inactive
@sbosio sbosio temporarily deployed to AcceptanceTests February 9, 2026 18:05 — with GitHub Actions Inactive
@sbosio sbosio force-pushed the sbosio/ngpg-attachments-and-quotas branch from e6fcd03 to d9862f2 Compare February 9, 2026 18:21
@sbosio sbosio temporarily deployed to AcceptanceTests February 9, 2026 18:21 — with GitHub Actions Inactive
@sbosio sbosio temporarily deployed to AcceptanceTests February 9, 2026 18:21 — with GitHub Actions Inactive
@sbosio sbosio temporarily deployed to AcceptanceTests February 9, 2026 18:21 — with GitHub Actions Inactive
@sbosio sbosio temporarily deployed to AcceptanceTests February 9, 2026 18:21 — with GitHub Actions Inactive
Copy link
Contributor

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one non-blocking question. Looks good!

@sbosio sbosio temporarily deployed to AcceptanceTests February 9, 2026 21:22 — with GitHub Actions Inactive
@sbosio sbosio temporarily deployed to AcceptanceTests February 9, 2026 21:22 — with GitHub Actions Inactive
@sbosio sbosio temporarily deployed to AcceptanceTests February 9, 2026 21:22 — with GitHub Actions Inactive
@sbosio sbosio temporarily deployed to AcceptanceTests February 9, 2026 21:22 — with GitHub Actions Inactive
@sbosio sbosio merged commit 8ea78eb into v11.0.0 Feb 9, 2026
13 checks passed
@sbosio sbosio deleted the sbosio/ngpg-attachments-and-quotas branch February 9, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants