-
Notifications
You must be signed in to change notification settings - Fork 234
activation of acceptance and integration tests #3520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
michaelmalave
merged 8 commits into
v11.0.0
from
mm/feat/activate-integration-and-acceptance
Feb 9, 2026
Merged
activation of acceptance and integration tests #3520
michaelmalave
merged 8 commits into
v11.0.0
from
mm/feat/activate-integration-and-acceptance
Feb 9, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2ce3b8 to
9978ec8
Compare
…ntegration-and-acceptance
sbosio
approved these changes
Feb 9, 2026
Contributor
sbosio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few non-blocking comments but overall it looks good, so I'm approving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-enabled integration and acceptance tests after the oclif/core v4 upgrade.
Type of Change
Verification
From repo root:
Additional Details
Helpers
Acceptance tests
bin/run) against appheroku-cli-ci-smoke-test-appand CI account.access,addons,apps,apps:info,auth:whoami,authorizations,autocomplete,buildpacks:search,certs,ci,ci:config,clients,config,container:login,domains,git:clone,help,local:version,pipelines,pg:backups,redis:credentials,regions,run,sessions,spaces,status,version,webhooks.plugins --corelists expected oclif plugins;commandsoutput is checked againstcommands-output.ts(every command id/summary present).@heroku-cli/plugin-applink): find innode_modules, clone repo, checkout version, runnpm installandnpm testin the clone (skipped on Windows).Bats
heroku local:run echo 'it works!'andheroku local:run exit 1; assert exit code and output.heroku local(and variants with-f Procfile.test,release); assert web/worker/test/release output.heroku local:version; assert output contains3.0.Integration tests
heroku access --app=heroku-cli-ci-smoke-test-app; output includes admin/collaborator anddeploy, manage, operate, view.heroku logs --app=heroku-cli-ci-smoke-test-app; output looks like logs (e.g. contains a year).heroku runon the smoke app: basicecho 1 2 3,--no-launcher, command with spaces, with quotes, with-e FOO=bar, and invalid command (“command not found”).heroku run:detached ... echo 1 2 3; output tells user to runheroku logs ... --dyno.Related Issue
Closes #W-19122519