fix: CPU ISA detection logic in standalone install script #3393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux, `uname -m` will report `aarch64` on 64-bit ARM CPUs. The previous logic in this script matched that against the expression `aarch*`, causing the script to wrongly select the 32-bit ARM architecture identifier, which gives a runtime error when launching the CLI due to the lack of 32-bit dynamic linker on the system (specifically, the error indicates that `ld-linux-armhf.so.3` is missing). Signed-off-by: Zach Mullen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux,
uname -mwill reportaarch64on 64-bit ARM CPUs. The previous logic in this script matched that against the expressionaarch*, causing the script to wrongly select the 32-bit ARM architecture identifier, which gives a runtime error when launching the CLI due to the lack of 32-bit dynamic linker on the system (specifically, the error indicates thatld-linux-armhf.so.3is missing).