Close #302 Copy Mtimes in the AppCache #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When copying from the cache back into the app, it should not replace files that already exist. This test asserts already passing behavior.
Adds tests for ensuring FIFO behavior in the cache works based on mime types. This comment #302 (comment). Currently it works locally but fails on CI, that tells me the mtime-preserving behavior is platform dependent.
Malax
approved these changes
Oct 18, 2024
Member
Malax
left a comment
Malax
left a comment
There was a problem hiding this comment.
I didn't give this a super deep review, but I looked into it. It looks good to me! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit compiles and is intended to be small and readable. More information on why this option was chosen is in #302 (comment)