Conversation
mkroening
reviewed
May 9, 2026
mkroening
left a comment
Member
There was a problem hiding this comment.
I've not done it this way deliberately, because without inline hints, I find
HermitVersion::new(0, 1, 2)less readable than
HermitVersion {
major: 0,
minor: 1,
patch: 2,
}Compare to the main usage of the semver crate (and tests).
Adding this is fine with me. This is similar to semver::Version::new, though that method functions to avoid spelling out pre and build.
I am unsure if changing the tests is the right call, but you can do as you wish. :)
Member
Author
|
Then let's merge it. It isn't a big thing but doesn't hurt. |
mkroening
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sole purpose of this function is to remove the four extra lines of code when instantiating this struct.