Skip to content

DS-1351: Ensure Job#validateStep() will never take longer than 10 seconds #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

DS-1351: Ensure Job#validateStep() will never take longer than 10 seconds #1554

wants to merge 3 commits into from

Conversation

roegi
Copy link
Contributor

@roegi roegi commented Jun 11, 2025

  • Add method to Async util that supports specifying a timeout
  • Switch implementation of Async tool to use standard ExecutorServices instead of the shared vertx WorkerExecutor
  • Add test to verify that the new Async#run() method with timeout is working properly
  • Increase the number of async workers for the Job class

roegi added 3 commits June 12, 2025 00:50
@roegi
DS-1351: Add method to Async util that supports specifying a timeout
9694f4c 
- Switch implementation of Async tool to use standard ExecutorServices instead of the shared vertx WorkerExecutor
- Add test to verify that the new Async#run() method with timeout is working properly

Signed-off-by: Benjamin Rögner <[email protected]>
@roegi
DS-1351: Ensure Job#validateStep() will never take longer than 10 sec…
22ea9f9 
…onds

- Add a timeout to the async call

Signed-off-by: Benjamin Rögner <[email protected]>
@roegi
DS-1351: Increase the number of async workers for the Job class
26588b6 
Signed-off-by: Benjamin Rögner <[email protected]>
@roegi roegi requested a review from a team as a code owner June 11, 2025 22:53
@roegi roegi requested a review from mchrza June 11, 2025 22:54
@roegi roegi marked this pull request as draft June 11, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchrza mchrza Awaiting requested review from mchrza

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@roegi