feat: support multi-document values files #13655
Open
+14
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
Signed-off-by: lubingtan <[email protected]>
|
Hello, thank you for your pull request. This function doesn't have any associated unit test for this. Is it possible to have that added to ensure we don't break functionality. |
gjenkins8
requested changes
Jan 25, 2025
There was a problem hiding this comment.
Along with @robertsirc comment about tests, this only addresses values files specified on the command line. I think for consistency, we should support multi-document values files for both cli overrides, and default chart values.
This also somewhat implies we should unify the value file load process between chart's and the cli.
(it could be argued we do one first, but at least my opinion is we should do both at thg same time for consistency)
|
Thanks for your comments! Let me update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
close #13097
Special notes for your reviewer: